feat: Add a configurable error handler for environment updates. Return response codes on HTTP errors #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove handler from pollEnvironment to UpdateEnvironment * Rename handler to errorHandler * Create a struct FlagsmithErrorHandler so that we can return error and other client response details
ajinkyasurya
force-pushed
the
ajinkyasurya/pollErrorHandler
branch
from
e660035 to
54ff6e5
Compare
rolodato
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Overall approach looks good, but I'd like to finalise the types/names with feedback from @gagantrivedi 👍
ajinkyasurya
changed the title
rolodato
approved these changes
Sep 30, 2024
rolodato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pollErrorHandler func(error)toClientstruct.pollEnvironment(), trigger callback function when UpdateEnvironment fails.